1996fanrui commented on code in PR #24098:
URL: https://github.com/apache/flink/pull/24098#discussion_r1454370046
##########
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java:
##########
@@ -246,6 +244,21 @@ public static String getTaskManagerShellCommand(
return startCommand;
}
+ public static String generateJvmOptsString(
Review Comment:
nit: It's better to add a simple unit test for this method before merging.
BTW, you can squash all commits directly after adding the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
