1996fanrui commented on code in PR #24098:
URL: https://github.com/apache/flink/pull/24098#discussion_r1454802472
##########
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java:
##########
@@ -191,17 +193,13 @@ public static String getTaskManagerShellCommand(
startCommandValues.put(
"jvmmem",
ProcessMemoryUtils.generateJvmParametersStr(taskExecutorProcessSpec));
- String javaOpts = flinkConfig.getString(CoreOptions.FLINK_JVM_OPTIONS);
- if (flinkConfig.getString(CoreOptions.FLINK_TM_JVM_OPTIONS).length() >
0) {
- javaOpts += " " +
flinkConfig.getString(CoreOptions.FLINK_TM_JVM_OPTIONS);
- }
- javaOpts += " " + IGNORE_UNRECOGNIZED_VM_OPTIONS;
-
- // krb5.conf file will be available as local resource in JM/TM
container
- if (hasKrb5) {
- javaOpts += " -Djava.security.krb5.conf=krb5.conf";
- }
- startCommandValues.put("jvmopts", javaOpts);
+ List<ConfigOption<String>> jvmOptions =
+ Arrays.asList(
+ CoreOptions.FLINK_DEFAULT_JVM_OPTIONS,
Review Comment:
https://github.com/apache/flink/pull/24089 moves the
`getTaskManagerShellCommand` from `flink-runtime` module to `flink-yarn` module.
So these 2 PRs have some conflicts. Would you mind merging #24089 first and
fix the conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
