snuyanzin commented on code in PR #89:
URL:
https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458035878
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcUtils.java:
##########
@@ -168,4 +168,14 @@ public static Row getPrimaryKey(Row row, int[] pkFields) {
}
return pkRow;
}
+
+ public static String handleDoubleQuotes(String identifier) {
+ String[] split = identifier.split("\\.");
+ StringBuilder builder = new StringBuilder();
+ for (String s : split) {
+ builder.append("\"").append(s).append("\"");
+ builder.append(".");
+ }
+ return builder.deleteCharAt(builder.length() - 1).toString();
+ }
Review Comment:
I didn't get why we are going to put logic with double quotes into some
generic place if for different engines there could be different quotes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
