BlackPigHe commented on code in PR #89:
URL:
https://github.com/apache/flink-connector-jdbc/pull/89#discussion_r1458581313
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/oracle/dialect/OraclePreparedStatementTest.java:
##########
@@ -48,10 +48,10 @@ void testInsertStatement() {
String insertStmt = dialect.getInsertIntoStatement(tableName,
fieldNames);
assertThat(insertStmt)
.isEqualTo(
- "INSERT INTO tbl(id, name, email, ts, field1, field_2,
__field_3__) "
+ "INSERT INTO \"tbl\"(\"id\", \"name\", \"email\",
\"ts\", \"field1\", \"field_2\", \"__field_3__\") "
+ "VALUES (:id, :name, :email, :ts, :field1,
:field_2, :__field_3__)");
NamedStatementMatcher.parsedSql(
- "INSERT INTO tbl(id, name, email, ts, field1, field_2,
__field_3__) "
+ "INSERT INTO \"tbl\"(\"id\", \"name\", \"email\",
\"ts\", \"field1\", \"field_2\", \"__field_3__\") "
Review Comment:
the method ‘quoteIdentifier’ is common，column metadata is also by call the
method.Columns should have this problem as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
