HuangZhenQiu commented on code in PR #23511:
URL: https://github.com/apache/flink/pull/23511#discussion_r1461398939


##########
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroToRowDataConverters.java:
##########
@@ -121,6 +128,12 @@ private static AvroToRowDataConverter 
createConverter(LogicalType type) {
                 return AvroToRowDataConverters::convertToTime;
             case TIMESTAMP_WITHOUT_TIME_ZONE:
                 return AvroToRowDataConverters::convertToTimestamp;

Review Comment:
   In the FLIP, we have proposed the new mapping. Does it cover both the change 
in AvroToRowDataConverters and RowDataToAvroConverters? 
   
   Avro Timestamp <-> Flink TIMESTAMP_WITH_LOCAL_TIME_ZONE
   additionally support Avro LocalTimestamp <-> Flink 
TIMESTAMP_WITHOUT_TIME_ZONE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to