leonardBang commented on code in PR #23511:
URL: https://github.com/apache/flink/pull/23511#discussion_r1461554379
##########
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java:
##########
@@ -339,7 +365,7 @@ private Time convertToTime(Object object) {
return new Time(millis - LOCAL_TZ.getOffset(millis));
}
- private Timestamp convertToTimestamp(Object object, boolean isMicros) {
+ private Timestamp convertToTimestamp(Object object, boolean isMicros,
boolean legacyMapping) {
Review Comment:
could you change all `legacyMapping ` in this PR, we’d better use
`legacyTimestampMapping `
##########
pom.xml:
##########
@@ -1840,7 +1840,7 @@ under the License.
<configuration>
<rules>
<requireMavenVersion>
-
<version>[3.8.6]</version>
+
<version>[3.8.6, 3.9.6]</version>
Review Comment:
We'd better do not change the parent pom here, we can add another PR to do
this work, because it's not related to this PR, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
