mxm commented on code in PR #759:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/759#discussion_r1461587441
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java:
##########
@@ -160,14 +160,23 @@ private void runScalingLogic(Context ctx,
AutoscalerFlinkMetrics autoscalerMetri
var collectedMetrics = metricsCollector.updateMetrics(ctx, stateStore);
var jobTopology = collectedMetrics.getJobTopology();
+ var now = clock.instant();
Review Comment:
Reconciliation is triggered at least once per minute, but actual
reconciliation time is more like 10-20 seconds. This is due cluster events also
triggering the reconciliation loop. However, I think you are right, we should
use the job update time and not the current time. Let's wait what Alex says.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
