lsyldliu commented on code in PR #24161:
URL: https://github.com/apache/flink/pull/24161#discussion_r1462830909
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/JoinUtil.scala:
##########
@@ -95,6 +105,18 @@ object JoinUtil {
}
}
+ /** Creates a MiniBatch trigger for join depends on the config. */
+ def createMiniBatchTrigger(config: ReadableConfig):
CountCoBundleTrigger[RowData, RowData] = {
Review Comment:
We can reuse the `AggregateUtil#createMiniBatchTrigger` method. Moreover, I
think we can extract a MinibatchUtil class, move minibatch related to utility
method to this class.
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/JoinUtil.scala:
##########
@@ -50,6 +52,14 @@ import scala.collection.JavaConversions._
/** Util for [[Join]]s. */
object JoinUtil {
+ /** Returns true if mini-batch for join is enabled. */
+ def isMiniBatchEnabled(config: ReadableConfig): Boolean = {
+ val enableMiniBatch =
config.get(ExecutionConfigOptions.TABLE_EXEC_MINIBATCH_ENABLED)
+ val miniBatchLatency =
Review Comment:
We can remove this check because
`StreamCommonSubGraphBasedOptimizer#doOptimize` method had checked it, And we
can remove this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
