libenchao commented on code in PR #24133:
URL: https://github.com/apache/flink/pull/24133#discussion_r1467163104
##########
docs/content/docs/connectors/table/datagen.md:
##########
@@ -270,6 +270,13 @@ Connector Options
<td>Long</td>
<td>The total number of rows to emit. By default, the table is
unbounded.</td>
</tr>
+ <tr>
+ <td><h5>scan.parallelism</h5></td>
+ <td>optional</td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Long</td>
Review Comment:
Actually it's defined as `int` in the code.
##########
flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java:
##########
@@ -581,6 +588,27 @@ void testWrongTypes() {
anyCauseMatches("Could not parse value 'Wrong' for key
'fields.f0.start'"));
}
+ @Test
+ void testWithParallelism() {
Review Comment:
In FLINK-33263, we've introduced a way to verify that the transformation,
could you also add a test based on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
