reswqa commented on code in PR #24151:
URL: https://github.com/apache/flink/pull/24151#discussion_r1467354290
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/UnionResultSubpartitionView.java:
##########
@@ -71,18 +73,35 @@ public class UnionResultSubpartitionView
private final Queue<Tuple2<ResultSubpartition.BufferAndBacklog, Integer>>
cachedBuffers =
new LinkedList<>();
+ /**
+ * A collection storing views that have triggered {@link
+ * #notifyDataAvailable(ResultSubpartitionView)} without {@link
#notifyViewCreated(int,
+ * ResultSubpartitionView)}. This is used to resolve the race condition
between these two
+ * methods.
+ */
+ private final Set<ResultSubpartitionView> unregisteredAvailableViews = new
HashSet<>();
Review Comment:
`@GuradedBy("lock")`
Please also check other fields if it is guarded by a lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
