z3d1k commented on code in PR #127:
URL:
https://github.com/apache/flink-connector-aws/pull/127#discussion_r1473727909
##########
pom.xml:
##########
@@ -58,7 +58,7 @@ under the License.
<netty.version>4.1.86.Final</netty.version>
<flink.version>1.17.0</flink.version>
<jackson-bom.version>2.14.3</jackson-bom.version>
- <glue.schema.registry.version>1.1.14</glue.schema.registry.version>
+ <glue.schema.registry.version>1.1.18</glue.schema.registry.version>
Review Comment:
Upgrading version to resolve the dependency convergence issues with
`snakeyaml` package between `flink-core` and `schema-registry-serde`.
New versions of `schema-registry-serde` no longer include `snakeyaml` as a
transitive dependency.
##########
flink-connector-aws/flink-connector-aws-kinesis-firehose/pom.xml:
##########
@@ -71,6 +71,12 @@ under the License.
<version>${flink.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-test-utils</artifactId>
+ <version>${flink.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Required to use `TestSinkInitContext`
##########
flink-connector-aws/flink-connector-kinesis/pom.xml:
##########
@@ -137,6 +137,12 @@ under the License.
</dependency>
<!-- Flink ecosystem -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-core</artifactId>
+ <version>${flink.version}</version>
+ <scope>provided</scope>
+ </dependency>
Review Comment:
Explicitly specifying dependency with the correct scope to prevent licensing
check failures on unused transitive dependencies (flink-shaded-jackson).
Previously `flink-core` has been transitively consumed through
`flink-streaming-java`, resulting in maven marking some of the packages as
included in `compile` scope.
##########
pom.xml:
##########
@@ -341,6 +341,16 @@ under the License.
<artifactId>amazon-kinesis-client</artifactId>
<version>1.14.8</version>
</dependency>
+ <dependency>
+ <groupId>com.squareup.okio</groupId>
+ <artifactId>okio</artifactId>
+ <version>3.4.0</version>
+ </dependency>
+ <dependency>
+ <groupId>com.squareup.okio</groupId>
+ <artifactId>okio-jvm</artifactId>
+ <version>3.4.0</version>
+ </dependency>
Review Comment:
Specified to resolve dependency convergence issues in
`schema-registry-serde`.
##########
flink-formats-aws/flink-json-glue-schema-registry/pom.xml:
##########
@@ -61,6 +61,14 @@ under the License.
<version>${glue.schema.registry.version}</version>
</dependency>
+ <!-- Test dependencies -->
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <version>1.18.30</version>
+ <scope>test</scope>
+ </dependency>
+
Review Comment:
Lombok had been consumed as transitive dependency of
`software.amazon.glue:schema-registry-serde`.
Starting from `schema-registry-serde` 1.1.15 it is no longer provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
