hackergin commented on code in PR #24235: URL: https://github.com/apache/flink/pull/24235#discussion_r1474303521
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkSqlCallBinding.java: ########## @@ -77,20 +76,15 @@ public List<SqlNode> operands() { @Override public RelDataType getOperandType(int ordinal) { - return isNamedArgument() && !argumentTypes.isEmpty() + return isNamedArgument() ? ((SqlOperandMetadata) getCall().getOperator().getOperandTypeChecker()) .paramTypes(typeFactory) .get(ordinal) : super.getOperandType(ordinal); } public boolean isNamedArgument() { - for (SqlNode operand : getCall().getOperandList()) { - if (operand != null && operand.getKind() == SqlKind.ARGUMENT_ASSIGNMENT) { - return !getArgumentTypes().isEmpty(); - } - } - return false; + return !argumentTypes.isEmpty(); Review Comment: Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org