snuyanzin commented on code in PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1475815795
########## .github/workflows/weekly.yml: ########## @@ -27,25 +27,13 @@ jobs: strategy: matrix: flink_branches: [{ - flink: 1.16-SNAPSHOT, - branch: main - }, { - flink: 1.17-SNAPSHOT, - branch: main - }, { flink: 1.18-SNAPSHOT, jdk: '8, 11, 17', branch: main }, { flink: 1.19-SNAPSHOT, jdk: '8, 11, 17, 21', branch: main - }, { - flink: 1.16.2, - branch: v3.1 - }, { - flink: 1.17.1, - branch: v3.1 }, { Review Comment: IIRC idealy we should support currently supported Flink versions (1.17, 1.18, 1.19 and 1.16 (probably will be not supported after 1.19 release)). I don't know another way to have all of them supported with out branching (4.0.0 or 3.2.0 doesn't really matter) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org