eskabetxe commented on code in PR #2:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1475842140


##########
.github/workflows/weekly.yml:
##########
@@ -27,25 +27,13 @@ jobs:
     strategy:
       matrix:
         flink_branches: [{
-          flink: 1.16-SNAPSHOT,
-          branch: main
-        }, {
-          flink: 1.17-SNAPSHOT,
-          branch: main
-        }, {
           flink: 1.18-SNAPSHOT,
           jdk: '8, 11, 17',
           branch: main
         }, {
           flink: 1.19-SNAPSHOT,
           jdk: '8, 11, 17, 21',
           branch: main
-        }, {
-          flink: 1.16.2,
-          branch: v3.1
-        }, {
-          flink: 1.17.1,
-          branch: v3.1
         }, {

Review Comment:
   We could release 3.2 (3.1.X) with current main code giving support for 1.17 
and 1.18 (1.18 still not support by any release), I don't know why still don't 
have release an 1.18 compatible version, any blocker?
   
   And them merge this and release again with (minor or major)..



##########
.github/workflows/weekly.yml:
##########
@@ -27,25 +27,13 @@ jobs:
     strategy:
       matrix:
         flink_branches: [{
-          flink: 1.16-SNAPSHOT,
-          branch: main
-        }, {
-          flink: 1.17-SNAPSHOT,
-          branch: main
-        }, {
           flink: 1.18-SNAPSHOT,
           jdk: '8, 11, 17',
           branch: main
         }, {
           flink: 1.19-SNAPSHOT,
           jdk: '8, 11, 17, 21',
           branch: main
-        }, {
-          flink: 1.16.2,
-          branch: v3.1
-        }, {
-          flink: 1.17.1,
-          branch: v3.1
         }, {

Review Comment:
   We could release 3.2 (3.1.X) with current main code giving support for 1.17 
and 1.18 (1.18 still not support by any release), I don't know why still don't 
have release an 1.18 compatible version, any blocker?
   
   And them merge this and release again with (minor or major)..
   Would this work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to