[
https://issues.apache.org/jira/browse/FLINK-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15676440#comment-15676440
]
ASF GitHub Bot commented on FLINK-5093:
---------------------------------------
GitHub user ifndef-SleePy opened a pull request:
https://github.com/apache/flink/pull/2828
[FLINK-5093] java.util.ConcurrentModificationException is thrown when
stopping TimerService
[FLINK-5093] Fix bug about java.util.ConcurrentModificationException thrown
while stopping TimerService. Add a new method "unregisterAllTimeouts" and UT
for it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alibaba/flink jira-5093
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2828.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2828
----
commit 21fdd8da33c634f5b6a19ed8ea7af9c18bcbe9bc
Author: biao.liub <[email protected]>
Date: 2016-11-18T10:15:37Z
[FLINK-5093] Fix bug about throwing ConcurrentModificationException when
stopping TimerService.
commit 24406bbe77ba211ce99f268a85adbb391cc605df
Author: biao.liub <[email protected]>
Date: 2016-11-18T10:32:36Z
[FLINK-5093] Remove useless import.
----
> java.util.ConcurrentModificationException is thrown when stopping TimerService
> ------------------------------------------------------------------------------
>
> Key: FLINK-5093
> URL: https://issues.apache.org/jira/browse/FLINK-5093
> Project: Flink
> Issue Type: Bug
> Components: Cluster Management
> Environment: FLIP-6 feature branch
> Reporter: Biao Liu
> Assignee: Biao Liu
> Priority: Minor
>
> In stop method of TimerService, removing Timeout instance while iterating the
> map will cause a java.util.ConcurrentModificationException.
> Here is the stack:
> java.util.ConcurrentModificationException
> at java.util.HashMap$HashIterator.nextEntry(HashMap.java:922)
> at java.util.HashMap$KeyIterator.next(HashMap.java:956)
> at
> org.apache.flink.runtime.taskexecutor.slot.TimerService.stop(TimerService.java:63)
> at
> org.apache.flink.runtime.taskexecutor.slot.TaskSlotTable.stop(TaskSlotTable.java:129)
> at
> org.apache.flink.runtime.taskexecutor.TaskExecutor.shutDown(TaskExecutor.java:224)
> at
> org.apache.flink.runtime.taskexecutor.TaskManagerRunner.shutDownInternally(TaskManagerRunner.java:135)
> at
> org.apache.flink.runtime.taskexecutor.TaskManagerRunner.shutDown(TaskManagerRunner.java:129)
> at
> org.apache.flink.runtime.minicluster.MiniCluster.shutdownInternally(MiniCluster.java:319)
> at
> org.apache.flink.runtime.minicluster.MiniCluster.shutdown(MiniCluster.java:274)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
