1996fanrui commented on code in PR #765:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1480012807
##########
docs/content/docs/custom-resource/autoscaler.md:
##########
@@ -286,16 +286,20 @@ please download JDBC driver and initialize database and
table first.
```
JDBC_DRIVER_JAR=./mysql-connector-java-8.0.30.jar
-# export the password of jdbc state store
+# export the password of jdbc state store & jdbc event handler
export STATE_STORE_JDBC_PWD=123456
+export EVENT_HANDLER_JDBC_PWD=123456
java -cp flink-autoscaler-standalone-{{< version >}}.jar:${JDBC_DRIVER_JAR} \
org.apache.flink.autoscaler.standalone.StandaloneAutoscalerEntrypoint \
--autoscaler.standalone.fetcher.flink-cluster.host localhost \
--autoscaler.standalone.fetcher.flink-cluster.port 8081 \
--autoscaler.standalone.state-store.type jdbc \
--autoscaler.standalone.state-store.jdbc.url
jdbc:mysql://localhost:3306/flink_autoscaler \
---autoscaler.standalone.state-store.jdbc.username root
+--autoscaler.standalone.state-store.jdbc.username root \
+--autoscaler.standalone.event-handler.type jdbc \
+--autoscaler.standalone.event-handler.jdbc.url
jdbc:mysql://localhost:3306/flink_autoscaler \
+--autoscaler.standalone.event-handler.jdbc.username root
Review Comment:
These database related options are similar between jdbcStateStore and
jdbcEventHandler. I'm not sure whether we should merge them or stay as is.
## Solution1: Merging them
Merge them means we rename `autoscaler.standalone.state-store.jdbc.username`
to `autoscaler.standalone.jdbc-plugin.username`. And both of jdbcStateStore and
jdbcEventHandler will use `autoscaler.standalone.jdbc-plugin.username` and
`autoscaler.standalone.jdbc-plugin.url`.
## Solution2: Independent options
Defining`autoscaler.standalone.event-handler.jdbc.url` and
`autoscaler.standalone.state-store.jdbc.url`, it means jdbcStateStore and
jdbcEventHandler can use different databases and different users.
I believe solution1 is pretty easy to use, and it's enough for most of
users.
WDYT? @gyfora @mxm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
