1996fanrui commented on code in PR #765:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1480045403
##########
docs/content/docs/custom-resource/autoscaler.md:
##########
@@ -286,16 +286,20 @@ please download JDBC driver and initialize database and
table first.
```
JDBC_DRIVER_JAR=./mysql-connector-java-8.0.30.jar
-# export the password of jdbc state store
+# export the password of jdbc state store & jdbc event handler
export STATE_STORE_JDBC_PWD=123456
+export EVENT_HANDLER_JDBC_PWD=123456
java -cp flink-autoscaler-standalone-{{< version >}}.jar:${JDBC_DRIVER_JAR} \
org.apache.flink.autoscaler.standalone.StandaloneAutoscalerEntrypoint \
--autoscaler.standalone.fetcher.flink-cluster.host localhost \
--autoscaler.standalone.fetcher.flink-cluster.port 8081 \
--autoscaler.standalone.state-store.type jdbc \
--autoscaler.standalone.state-store.jdbc.url
jdbc:mysql://localhost:3306/flink_autoscaler \
---autoscaler.standalone.state-store.jdbc.username root
+--autoscaler.standalone.state-store.jdbc.username root \
+--autoscaler.standalone.event-handler.type jdbc \
+--autoscaler.standalone.event-handler.jdbc.url
jdbc:mysql://localhost:3306/flink_autoscaler \
+--autoscaler.standalone.event-handler.jdbc.username root
Review Comment:
I'm still working on this PR now, I found it's better to include this PR in
`1.8.0`. Because I believe jdbcStateStore and jdbcEventHandler always work
together.
During I test the `jdbcEventHandler`, I found some defects of
`jdbcStateStore`, such as: FLINK-34389, this comment
https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1480012807.
It means if we includes `jdbcEventHandler` in this version we can ensure
they work well together. If we release the jdbcStateStore in this version, and
release jdbcEventHandler in the next version. We might need to change the
jdbcStateStore again in the next version. It's better to release a final
version for users, and it won't introduce any incompatibility problem.
So I'd like to increase this priority, WDYT?
Note: the prod code is done(you can help review if you are free), and the
progress of unit test and ITCase is about 40% and I will finish it asap..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
