snuyanzin commented on code in PR #24302:
URL: https://github.com/apache/flink/pull/24302#discussion_r1487487950
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/VeryBigPbProtoToRowITCase.java:
##########
@@ -25,8 +25,11 @@
/**
* Test for very huge proto definition, which may trigger some special
optimizations such as code
* splitting and java constant pool size optimization.
+ *
+ * <p>Implementing this test as an {@code ITCase} enables larger heap size for
the test execution.
Review Comment:
```suggestion
* <p>@implNote Implementing this test as an {@code ITCase} enables larger
heap size for the test execution.
```
nit should we use `@implNote` here which came with
https://bugs.openjdk.org/browse/JDK-8008632?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
