XComp commented on code in PR #24302:
URL: https://github.com/apache/flink/pull/24302#discussion_r1487496290


##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/VeryBigPbProtoToRowITCase.java:
##########
@@ -25,8 +25,11 @@
 /**
  * Test for very huge proto definition, which may trigger some special 
optimizations such as code
  * splitting and java constant pool size optimization.
+ *
+ * <p>Implementing this test as an {@code ITCase} enables larger heap size for 
the test execution.

Review Comment:
   interesting. I didn't know about it. It [seems to 
be](https://stackoverflow.com/a/55150289) supported by Intellij. I tried it. We 
have issues with checkstyle complaining about "an unknown JavaDoc tag". I tend 
to not use it because of that. We might have to update checkstyle first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to