1996fanrui commented on code in PR #765:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/765#discussion_r1490909393
##########
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java:
##########
@@ -109,4 +110,51 @@ private static ConfigOptions.OptionBuilder
autoscalerStandaloneConfig(String key
+ "export the password
using this environment variable.",
code(STATE_STORE_TYPE.key()),
code(JDBC.toString()))
.build());
+
+ public static final ConfigOption<EventHandlerType> EVENT_HANDLER_TYPE =
+ autoscalerStandaloneConfig("event-handler.type")
+ .enumType(EventHandlerType.class)
+ .defaultValue(EventHandlerType.LOGGING)
+ .withDescription("The autoscaler event handler type.");
Review Comment:
Sorry, I misunderstand your question before, thanks for your clarification!
> I meant what if I want to print both to the console and store in JDBC?
Currently there can only be one event handler active at a time.
You are right, currently there are only be one event handler or state store
active at a time. I see kubernetes operator is similar, kubernetes operator
only creates one event handler or state store.
If users want to use multiple event handlers, I can implement
`CompositeEventHandler` in the future. Users can configure:
```
--autoscaler.standalone.event-handler.type composite
--autoscaler.standalone.event-handler.composite.types jdbc,logging
```
The `CompositeStateStore` is similar to `CompositeEventHandler`:
```
--autoscaler.standalone.state-store.type composite
--autoscaler.standalone.state-store.composite.types jdbc,memory
```
In the short term, it seems unnecessary. I can implement them in the future
if some users feedback it's useful in some scenarios. What do you think about
the solution and time plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
