snuyanzin commented on code in PR #24317:
URL: https://github.com/apache/flink/pull/24317#discussion_r1495657249
##########
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java:
##########
@@ -107,6 +107,10 @@ void testExplainAsDot() {}
void testStringAgg() {}
// END
+ @Disabled
Review Comment:
If we are talking about this concrete case then ideally it should be fixed
before merging this PR
and I'm trying to find a way how to do that, similar issue was highlighted
in Calcite related PR
If we are talking about in general then it is a normal way to turn off
Calcite parser tests if for some reason parser features for Calcite and Flink
are different since we can not override these tests (Calcite does not allow it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
