snuyanzin commented on code in PR #24317: URL: https://github.com/apache/flink/pull/24317#discussion_r1495660945
########## flink-table/flink-sql-parser/src/main/codegen/templates/Parser.jj: ########## @@ -0,0 +1,8469 @@ +/* Review Comment: IIRC we could extend it if we want something completly new e.g. support of `ADD JAR` feature or new keyword, functions and etc. However the problem here that we need override parser's behavior how it parses `FROM` clause to read tables which should be joined... And this looks unextendable ... At least I was not able to find a way to override it in a simpler way Would be great if there are other ideas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
