JingGe commented on code in PR #24338:
URL: https://github.com/apache/flink/pull/24338#discussion_r1498379848
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/TableDistribution.java:
##########
@@ -142,4 +142,9 @@ && getBucketCount().get() != 0) {
sb.append("\n");
return sb.toString();
}
+
+ @Override
+ public String toString() {
+ return asSerializableString();
Review Comment:
1. If this is the requirement of `toString()` method. We shoul consider
marking `asSerializableString()` as private and replace any external call of
`asSerializableString()` with `toString()`.
2. Could you also add a test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
