z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501900684
########## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/SinkMetrics.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.prometheus.sink; + +import org.apache.flink.metrics.Counter; +import org.apache.flink.metrics.MetricGroup; + +/** Wraps all metrics in a single class. */ +public class SinkMetrics { + private final Counter[] counters; + + private SinkMetrics(Counter[] counters) { + this.counters = counters; + } + + public void inc(SinkCounter counter, long value) { + counters[counter.ordinal()].inc(value); + } + + public void inc(SinkCounter counter) { + counters[counter.ordinal()].inc(); + } + + /** Register all custom sink metrics and return an of this wrapper class. */ + public static SinkMetrics registerSinkMetrics(MetricGroup metrics) { + // Register all counters + Counter[] counters = new Counter[SinkCounter.values().length]; + for (SinkCounter metric : SinkCounter.values()) { + counters[metric.ordinal()] = metrics.counter(metric.getMetricName()); + } + return new SinkMetrics(counters); + } + + /** Enum defining all sink counters. */ + public enum SinkCounter { + // Total number of Samples that were dropped because of not being retriable errors in + // Prometheus Review Comment: Here and below: replace comment with JavaDoc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
