Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2629#discussion_r88720966
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -982,7 +980,12 @@ public void executeCheckpointing() throws Exception {
startSyncPartNano = System.nanoTime();
- for (StreamOperator<?> op : allOperators) {
+ // perform the snapshots from head operator so that all
parent operators can do snapshot before their
+ // children. for chained operators without any future
wait operator/async wait operator, the order
+ // is not a concern. when it comes to chained operator
with those operators, all the operators acting as
+ // wait operators' children should have received all
their inputs while doing snapshot.
--- End diff --
I'm not sure how relevant this is anymore, because the output should happen
under the checkpoint lock and if the code is here (executing the checkpoint),
then it should already have acquired this lock.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
