Zakelly commented on code in PR #24402:
URL: https://github.com/apache/flink/pull/24402#discussion_r1507058342
##########
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##########
@@ -169,6 +173,26 @@ public class CheckpointingOptions {
+ "deactivated. Local recovery currently
only covers keyed state backends "
+ "(including both the
EmbeddedRocksDBStateBackend and the HashMapStateBackend).");
+ /**
+ * This option configures local backup for the state backend, which
indicates whether to make
+ * backup checkpoint on local disk. If not configured, fallback to {@link
+ * StateRecoveryOptions#LOCAL_RECOVERY}. By default, local backup is
deactivated. Local backup
+ * currently only covers keyed state backends (including both the
EmbeddedRocksDBStateBackend
+ * and the HashMapStateBackend).
+ */
+ public static final ConfigOption<Boolean> LOCAL_BACKUP_ENABLED =
+ ConfigOptions.key("execution.checkpointing.local-backup.enabled")
+ .booleanType()
+
.defaultValue(StateRecoveryOptions.LOCAL_RECOVERY.defaultValue())
+
.withFallbackKeys(StateRecoveryOptions.LOCAL_RECOVERY.key())
Review Comment:
I'm thinking does it make sense to make `'LOCAL_BACKUP_ENABLED'` as fallback
keys of the new `'LOCAL_RECOVERY'` instead of the reverse order? Since whether
to recover from local is typically set aligned with whether to make local
backup.
And both options should have same deprecated keys
'state.backend.local-recovery'.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalBackupAndRecoveryDirectoryProvider.java:
##########
@@ -48,7 +48,7 @@
*
* <p>
*/
-public interface LocalRecoveryDirectoryProvider extends Serializable {
+public interface LocalBackupAndRecoveryDirectoryProvider extends Serializable {
Review Comment:
I'd suggest name it 'LocalBackupDirectoryProvider' or keep the original
name. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
