dawidwys commented on code in PR #24219:
URL: https://github.com/apache/flink/pull/24219#discussion_r1514647722
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##########
@@ -90,16 +90,27 @@
public abstract class RestoreTestBase implements TableTestProgramRunner {
private final Class<? extends ExecNode<?>> execNodeUnderTest;
+ private final List<Class<? extends ExecNode<?>>> childExecNodesUnderTest;
private final AfterRestoreSource afterRestoreSource;
protected RestoreTestBase(Class<? extends ExecNode<?>> execNodeUnderTest) {
this.execNodeUnderTest = execNodeUnderTest;
+ this.childExecNodesUnderTest = new ArrayList<>();
+ this.afterRestoreSource = AfterRestoreSource.FINITE;
+ }
+
+ protected RestoreTestBase(
+ Class<? extends ExecNode<?>> execNodeUnderTest,
+ List<Class<? extends ExecNode<?>>> childExecNodesUnderTest) {
+ this.execNodeUnderTest = execNodeUnderTest;
+ this.childExecNodesUnderTest = childExecNodesUnderTest;
this.afterRestoreSource = AfterRestoreSource.FINITE;
}
Review Comment:
I strongly believe we should always redirect to a single ctor. Otherwise
it's really hard to track what's initialised where.
I must've missed that when reviewing adding previous ctors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
