leonardBang commented on code in PR #2988:
URL: https://github.com/apache/flink-cdc/pull/2988#discussion_r1527879357


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-sql-connector-tidb-cdc/pom.xml:
##########
@@ -60,6 +60,12 @@ under the License.
                                 </includes>
                             </artifactSet>
                             <relocations>
+                                <relocation>
+                                    <pattern>org.apache.kafka</pattern>
+                                    <shadedPattern>
+                                        
com.ververica.cdc.connectors.shaded.org.apache.kafka

Review Comment:
   Maybe we should change `  com.ververica.`  to `org.apache.flink` after we 
donated to Apache?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to