Shawn-Hx commented on code in PR #2988:
URL: https://github.com/apache/flink-cdc/pull/2988#discussion_r1535319684


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-sql-connector-tidb-cdc/pom.xml:
##########
@@ -60,6 +60,12 @@ under the License.
                                 </includes>
                             </artifactSet>
                             <relocations>
+                                <relocation>
+                                    <pattern>org.apache.kafka</pattern>
+                                    <shadedPattern>
+                                        
com.ververica.cdc.connectors.shaded.org.apache.kafka

Review Comment:
   > I found no shaded pattern has migrated from 
`com.ververica.cdc.connectors.shaded` yet. Maybe we should do it all together 
in an other PR?
   
   See https://github.com/apache/flink-cdc/pull/3110.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to