Zakelly commented on code in PR #24461:
URL: https://github.com/apache/flink/pull/24461#discussion_r1534971391
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/CoordinatedSourceRescaleITCase.java:
##########
@@ -122,8 +121,9 @@ private StreamExecutionEnvironment createEnv(
env.setParallelism(p);
env.enableCheckpointing(100);
env.getCheckpointConfig()
- .setExternalizedCheckpointCleanup(
-
CheckpointConfig.ExternalizedCheckpointCleanup.RETAIN_ON_CANCELLATION);
+ .setExternalizedCheckpointCleanupRetention(
Review Comment:
Actually I'd prefer `setExternalizedCheckpointRetention` @masteryhx WDYT?
##########
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/DataStreamAllroundTestJobFactory.java:
##########
@@ -303,22 +302,24 @@ private static void setupCheckpointing(
ENVIRONMENT_EXTERNALIZE_CHECKPOINT_CLEANUP.key(),
ENVIRONMENT_EXTERNALIZE_CHECKPOINT_CLEANUP.defaultValue());
- CheckpointConfig.ExternalizedCheckpointCleanup cleanupMode;
+ org.apache.flink.configuration.ExternalizedCheckpointCleanup
cleanupMode;
Review Comment:
Can we import this on top?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
