fredia commented on code in PR #24513:
URL: https://github.com/apache/flink/pull/24513#discussion_r1537383062
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##########
@@ -278,7 +300,11 @@ public SegmentFileStateHandle
closeStreamAndCreateStateHandle(
returnPhysicalFileForNextReuse(subtaskKey,
checkpointId, physicalFile);
return new SegmentFileStateHandle(
- physicalFile.getFilePath(), startPos,
stateSize, scope);
+ getManagedDirStateHandle(subtaskKey,
scope),
Review Comment:
Good catch, I moved the subtask dir of shared state to
`FileMergingOperatorStreamStateHandle`, directory will be registered even if
there is no state, so the directory can be deleted by JM in claim mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
