fredia commented on code in PR #24513:
URL: https://github.com/apache/flink/pull/24513#discussion_r1538560216
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackendSnapshotStrategy.java:
##########
@@ -204,7 +217,17 @@ public SnapshotResultSupplier<OperatorStateHandle>
asyncSnapshot(
if (snapshotCloseableRegistry.unregisterCloseable(localOut)) {
StreamStateHandle stateHandle = localOut.closeAndGetHandle();
if (stateHandle != null) {
Review Comment:
`SnapshotResult.of(null)` will be returned.
Theoretically, this situation cannot happen, because
`registeredOperatorStatesDeepCopies` and `registeredBroadcastStatesDeepCopies`
are checked at the beginning. At thisline, one of `OperatorStates` or
`BroadcastStates` is definitely not empty, and there must be content written to
the output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
