ashangit commented on code in PR #24563:
URL: https://github.com/apache/flink/pull/24563#discussion_r1538900208
##########
docs/layouts/shortcodes/generated/high_availability_configuration.html:
##########
@@ -68,6 +80,12 @@
<td>Integer</td>
<td>Defines the session timeout for the ZooKeeper session in
ms.</td>
</tr>
+ <tr>
+
<td><h5>high-availability.zookeeper.client.simulated-session-expiration-percent</h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Integer</td>
+ <td>Curator has the option of attempting to monitor session
expiration above what is provided by ZooKeeper. The percentage set by this
method determines how and if Curator will check for session expiration. If it
is set to 0, Curator does not do any additional checking for session
expiration. If a positive number is set, Curator will check for session
expiration as follows: when ZooKeeper sends a Disconnect event, Curator will
start a timer. If re-connection is not achieved before the elapsed time exceeds
the negotiated session time multiplied by the session expiration percent,
Curator will simulate a session expiration. Due to timing/network issues, it is
not possible for a client to match the server's session timeout with complete
accuracy. Thus, the need for a session expiration percentage.If not set the
default configuration for a Curator would be used.</td>
Review Comment:
```suggestion
<td>Curator has the option of attempting to monitor session
expiration above what is provided by ZooKeeper. The percentage set by this
method determines how and if Curator will check for session expiration. If it
is set to 0, Curator does not do any additional checking for session
expiration. If a positive number is set, Curator will check for session
expiration as follows: when ZooKeeper sends a Disconnect event, Curator will
start a timer. If re-connection is not achieved before the elapsed time exceeds
the negotiated session time multiplied by the session expiration percent,
Curator will simulate a session expiration. Due to timing/network issues, it is
not possible for a client to match the server's session timeout with complete
accuracy. Thus, the need for a session expiration percentage. If not set the
default configuration for a Curator would be used.</td>
```
##########
docs/layouts/shortcodes/generated/high_availability_configuration.html:
##########
@@ -38,6 +38,12 @@
<td>String</td>
<td>Defines the ACL (open|creator) to be configured on ZK node.
The configuration value can be set to “creator” if the ZooKeeper server
configuration has the “authProvider” property mapped to use
SASLAuthenticationProvider and the cluster is configured to run in secure mode
(Kerberos).</td>
</tr>
+ <tr>
+ <td><h5>high-availability.zookeeper.client.authorization</h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>Map</td>
+ <td>Add connection authorization Subsequent calls to this method
overwrite the prior calls. In certain cases ZooKeeper requires additional
Authorization information. For example list of valid names for ensemble in
order to prevent the accidental connecting to a wrong ensemble.Each entry of
type Map.Entry<String, String> will be transformed into an AuthInfo
object with the constructor AuthInfo(String, byte[]). The field entry.key()
will serve as the String scheme value, while the field entry.getValue() will be
initially converted to a byte[] using the String#getBytes() method with UTF8
encodingIf not set the default configuration for a Curator would be
applied.</td>
Review Comment:
```suggestion
<td>Add connection authorization Subsequent calls to this method
overwrite the prior calls. In certain cases ZooKeeper requires additional
Authorization information. For example list of valid names for ensemble in
order to prevent the accidental connecting to a wrong ensemble. Each entry of
type Map.Entry<String, String> will be transformed into an AuthInfo
object with the constructor AuthInfo(String, byte[]). The field entry.key()
will serve as the String scheme value, while the field entry.getValue() will be
initially converted to a byte[] using the String#getBytes() method with UTF8
encoding. If not set the default configuration for a Curator would be
applied.</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
