JTaky commented on code in PR #24563:
URL: https://github.com/apache/flink/pull/24563#discussion_r1540721696


##########
flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java:
##########
@@ -220,6 +222,52 @@ public class HighAvailabilityOptions {
                                                     + "with unresolvable 
hostnames.")
                                     .build());
 
+    public static final ConfigOption<Map<String, String>> 
ZOOKEEPER_CLIENT_AUTHORIZATION =
+            key("high-availability.zookeeper.client.authorization")
+                    .mapType()
+                    .noDefaultValue()
+                    .withDescription(
+                            Description.builder()
+                                    .text(
+                                            "Add connection authorization 
Subsequent calls to this method overwrite the prior calls. "
+                                                    + " In certain cases 
ZooKeeper requires additional Authorization information. "
+                                                    + "For example list of 
valid names for ensemble in order to prevent the accidental connecting to a 
wrong ensemble."
+                                                    + "Each entry of type 
Map.Entry<String, String> will be transformed into an AuthInfo object with the 
constructor AuthInfo(String, byte[]). "
+                                                    + "The field entry.key() 
will serve as the String scheme value, while the field entry.getValue() will be 
initially converted to a byte[] using the String#getBytes() method with UTF8 
encoding"
+                                                    + "If not set the default 
configuration for a Curator would be applied.")
+                                    .build());
+
+    public static final ConfigOption<Integer> ZOOKEEPER_MAX_CLOSE_WAIT_MS =
+            key("high-availability.zookeeper.client.max-close-wait-ms")
+                    .intType()

Review Comment:
   Thanks, will apply the duration type and add the appropriate conversion (to 
ms and to int) during the utilisation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to