PatrickRen commented on code in PR #3083:
URL: https://github.com/apache/flink-cdc/pull/3083#discussion_r1549418772


##########
pom.xml:
##########
@@ -462,8 +462,15 @@ under the License.
                                         submodules, ${flink.version} will be 
resolved as the actual Flink version.
                                     -->
                                     
<include>org.apache.flink:flink-shaded-force-shading</include>
+                                    
<include>org.apache.flink:flink-shaded-guava</include>
                                 </includes>
                             </artifactSet>
+                            <relocations>
+                                <relocation>
+                                    <pattern>flink.shaded.guava</pattern>

Review Comment:
   I'm not an expert of `maven-shade-plugin`, but I assume that the pattern 
should start with `org.apache.flink`. Please correct me if I'm wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to