loserwang1024 commented on code in PR #3083:
URL: https://github.com/apache/flink-cdc/pull/3083#discussion_r1554797030
##########
pom.xml:
##########
@@ -462,8 +462,15 @@ under the License.
submodules, ${flink.version} will be
resolved as the actual Flink version.
-->
<include>org.apache.flink:flink-shaded-force-shading</include>
+
<include>org.apache.flink:flink-shaded-guava</include>
</includes>
</artifactSet>
+ <relocations>
+ <relocation>
+ <pattern>flink.shaded.guava</pattern>
Review Comment:
Done it.(By the way, I used to use `com.google.guava` rather than flink's
shaded guava, but there are lots of limit in `checkstyle.xml`):
```xml
<module name="Regexp">
<property name="format" value="import
com\.google\.common\.base\.Preconditions"/>
<property name="illegalPattern" value="true"/>
<property name="message"
value="Use Flink's Preconditions instead of Guava's
Preconditions"/>
</module>
```
or
```xml
<module name="IllegalImport">
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="{0}; Use
flink-shaded-guava instead."/>
</module>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
