MartijnVisser commented on code in PR #89: URL: https://github.com/apache/flink-connector-kafka/pull/89#discussion_r1549969179
########## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSerializerWrapperTest.java: ########## @@ -0,0 +1,28 @@ +package org.apache.flink.connector.kafka.sink; + +import org.apache.flink.streaming.connectors.kafka.testutils.SerializationTestBase; +import org.apache.kafka.common.serialization.StringSerializer; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.junit.MockitoJUnitRunner; + +import static org.mockito.Mockito.when; + +@RunWith(MockitoJUnitRunner.class) Review Comment: Per the code style and quality guide, please don't use Mockito https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#avoid-mockito---use-reusable-test-implementations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
