hugogu commented on code in PR #89:
URL:
https://github.com/apache/flink-connector-kafka/pull/89#discussion_r1555387996
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSerializerWrapperTest.java:
##########
@@ -0,0 +1,63 @@
+package org.apache.flink.connector.kafka.sink;
+
+import org.apache.flink.api.common.serialization.SerializationSchema;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.metrics.groups.UnregisteredMetricsGroup;
+import org.apache.flink.util.FlinkUserCodeClassLoaders;
+import org.apache.flink.util.SimpleUserCodeClassLoader;
+import org.apache.flink.util.UserCodeClassLoader;
+
+import org.apache.kafka.common.serialization.StringSerializer;
+import org.junit.Test;
+
+import java.net.URL;
+
+import static org.junit.Assert.assertEquals;
+
+/** Tests for {@link KafkaSerializerWrapper}. */
+public class KafkaSerializerWrapperTest {
+ @Test
+ public void testUserCodeClassLoaderIsUsed() throws Exception {
+ final KafkaSerializerWrapperCaptureForTest wrapper =
+ new KafkaSerializerWrapperCaptureForTest();
+ final ClassLoader classLoader =
+ FlinkUserCodeClassLoaders.childFirst(
+ new URL[0],
+ getClass().getClassLoader(),
+ new String[0],
+ throwable -> {},
+ true);
+ wrapper.open(
+ new SerializationSchema.InitializationContext() {
+ @Override
+ public MetricGroup getMetricGroup() {
+ return new UnregisteredMetricsGroup();
+ }
+
+ @Override
+ public UserCodeClassLoader getUserCodeClassLoader() {
+ return SimpleUserCodeClassLoader.create(classLoader);
+ }
+ });
+
+ assertEquals(classLoader, wrapper.getClassLoaderUsed());
+ }
Review Comment:
Sure. Just added a couple tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
