1996fanrui commented on code in PR #24653:
URL: https://github.com/apache/flink/pull/24653#discussion_r1590792872
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java:
##########
@@ -327,6 +327,15 @@ public class ExecutionCheckpointingOptions {
.defaultValue(false)
.withDescription("Flag to enable approximate local
recovery.");
+ // TODO: deprecated
+ // Currently, both two mechanism can work simultaneously:
+ // 1. If UNALIGNED_MAX_SUBTASKS_PER_CHANNEL_STATE_FILE=1 and
+ // state.checkpoints.file-merging.enabled: true, only the unified file
merging mechanism takes
+ // effect.
+ // 2. if UNALIGNED_MAX_SUBTASKS_PER_CHANNEL_STATE_FILE>1 and
+ // state.checkpoints.file-merging.enabled: false, only the current
mechanism takes effect.
+ // 3. if UNALIGNED_MAX_SUBTASKS_PER_CHANNEL_STATE_FILE>1 and
+ // state.checkpoints.file-merging.enabled: true, both two mechanism take
effect.
Review Comment:
Wow, this comment is useful for understanding, great job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
