snuyanzin commented on code in PR #19797:
URL: https://github.com/apache/flink/pull/19797#discussion_r1600062134
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/agg/OverAggregateTest.scala:
##########
@@ -47,6 +48,18 @@ class OverAggregateTest extends TableTestBase {
util.verifyExecPlan("SELECT c, SUM(a) OVER (ORDER BY b) FROM MyTable")
}
+ @Test
+ def testDenseRankOnOrder(): Unit = {
Review Comment:
>I've attempted this case, and it seems only possible to test it within an
integration test in stream mode. I propose we can add another testRankOnOver
test specifically for testing the RANK() function.
this I didn't get, there is already`testRankOnOver`, would you like to add
another one?
>Maybe we'd better address this as well
yep, makes sense, I extracted the logic and reused it for
§createPercentRankAggFunction` as well
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/agg/OverAggregateTest.scala:
##########
@@ -47,6 +48,18 @@ class OverAggregateTest extends TableTestBase {
util.verifyExecPlan("SELECT c, SUM(a) OVER (ORDER BY b) FROM MyTable")
}
+ @Test
+ def testDenseRankOnOrder(): Unit = {
Review Comment:
>I've attempted this case, and it seems only possible to test it within an
integration test in stream mode. I propose we can add another testRankOnOver
test specifically for testing the RANK() function.
this I didn't get, there is already`testRankOnOver`, would you like to add
another one?
>Maybe we'd better address this as well
yep, makes sense, I extracted the logic and reused it for
§createPercentRankAggFunction` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
