snuyanzin commented on code in PR #19797:
URL: https://github.com/apache/flink/pull/19797#discussion_r1600155947
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/agg/OverAggregateTest.scala:
##########
@@ -47,6 +48,18 @@ class OverAggregateTest extends TableTestBase {
util.verifyExecPlan("SELECT c, SUM(a) OVER (ORDER BY b) FROM MyTable")
}
+ @Test
+ def testDenseRankOnOrder(): Unit = {
Review Comment:
Besides plans there are already a test in `OverAggregateITCase. scala` both
for `RANK` and `DENSE_RANK`, that's way I have this question
https://github.com/apache/flink/pull/19797/files#diff-0fa625835219d2a3fcacb2fa8de5274ed6795f10b06035c6c9b68d11b700f9a8R198-R203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
