XComp commented on code in PR #24471: URL: https://github.com/apache/flink/pull/24471#discussion_r1600075906
########## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/GeneratedRow.java: ########## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.tests; + +import org.apache.flink.table.data.ArrayData; +import org.apache.flink.table.data.DecimalData; +import org.apache.flink.table.data.MapData; +import org.apache.flink.table.data.RawValueData; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.data.StringData; +import org.apache.flink.table.data.TimestampData; +import org.apache.flink.types.RowKind; + +import java.io.Serializable; +import java.time.LocalDateTime; +import java.util.Objects; + +class GeneratedRow implements RowData, Serializable { Review Comment: Was there a reason to implement a dedicated `RowData`subclass rather than using the `Row`class like it's done in the original test code? 🤔 ########## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.tests; + +import org.apache.flink.table.data.RowData; + +import org.jetbrains.annotations.NotNull; + +import java.time.Instant; +import java.time.LocalDateTime; +import java.time.ZoneOffset; +import java.util.Iterator; +import java.util.NoSuchElementException; + +class Generator implements Iterator<RowData>, Iterable<RowData> { + final int numKeys; Review Comment: ```suggestion private final int numKeys; ``` There is no real reason to make this field a package-private one, does it? 🤔 ########## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.tests; + +import org.apache.flink.table.data.RowData; + +import org.jetbrains.annotations.NotNull; + +import java.time.Instant; +import java.time.LocalDateTime; +import java.time.ZoneOffset; +import java.util.Iterator; +import java.util.NoSuchElementException; + +class Generator implements Iterator<RowData>, Iterable<RowData> { + final int numKeys; + + private int keyIndex = 0; + + private final long durationMs; + private final long stepMs; + private final long offsetMs; + private long ms = 0; + + static Generator create( + int numKeys, float rowsPerKeyAndSecond, int durationSeconds, int offsetSeconds) { + int sleepMs = (int) (1000 / rowsPerKeyAndSecond); + return new Generator(numKeys, durationSeconds * 1000L, sleepMs, offsetSeconds * 2000L); + } + + Generator(int numKeys, long durationMs, long stepMs, long offsetMs) { + this.numKeys = numKeys; + this.durationMs = durationMs; + this.stepMs = stepMs; + this.offsetMs = offsetMs; + } + + @Override + public boolean hasNext() { + return ms < durationMs; + } + + @Override + public RowData next() { + if (!hasNext()) { + throw new NoSuchElementException(); + } + RowData row = + new GeneratedRow( + keyIndex, + LocalDateTime.ofInstant( + Instant.ofEpochMilli(ms + offsetMs), ZoneOffset.UTC), + "Some payload..."); + ++keyIndex; + if (keyIndex >= numKeys) { + keyIndex = 0; + ms += stepMs; + } + return row; + } + + @NotNull Review Comment: ```suggestion ``` nit & fyi: `@NotNull` annotations are obsolete. See [Flink's code conventions](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#nullability-of-the-mutable-parts) > Fields, parameters, and return types are always non-null, unless indicated otherwise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
