affo commented on PR #24471: URL: https://github.com/apache/flink/pull/24471#issuecomment-2127135299
@XComp Hello! Final touches done and your comments are addressed 👍 I added the capability for `FromElementsSource` to accept a `ElementsSupplier` at init phase. The problem for which I had to implement a `Serializable extend RowData` was due to the fact that the `FromElementsSource` had a field `List<OUT> elements`, where `OUT` can also be non-serializable (which is the case of `RowData`), so, when the job was starting the operator couldn't be serialized. I made it accept a `ElementsSupplier extends Serializable` so that it is clear that the supplier should be serializable. In my use case, I simply made the quirk that I preserved the previous implementation using `Row` (which is serializable) and just convert it to `RowData` on `get`. No class has now `RowData` fields that prevent their serializability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
