[
https://issues.apache.org/jira/browse/FLINK-35287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848440#comment-17848440
]
Weijie Guo commented on FLINK-35287:
------------------------------------
main via 0b6d9f823d9831816a81d02c0c1f367746363688.
> Builder builds NetworkConfig for Elasticsearch connector 8
> ----------------------------------------------------------
>
> Key: FLINK-35287
> URL: https://issues.apache.org/jira/browse/FLINK-35287
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / ElasticSearch
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Priority: Major
> Labels: pull-request-available
> Fix For: elasticsearch-3.1.0
>
>
> In FLINK-26088 we added support for ElasticSearch 8.0. It is based on Async
> sink API and does not use the base module
> {{flink-connector-elasticsearch-base}}. Regarding the config options (host,
> username, password, headers, ssl...), we pass all options from the builder to
> AsyncSink, and last to AsyncWriter. It is less flexible when we add new
> options and the constructors will get longer and multiple places may validate
> options unnecessarily. I think it's nice if we make the sink builder builds
> the NetworkConfig once, and pass it all the way to the writer. This is also
> how the base module for 6.x / 7.x is implemented. In my recent work adding
> new options to the network config, this way works simpler.
> Let me create a PR to demonstrate the idea. No new features or major code
> refactoring other than the builder builds the NetworkConfig (code will be
> shorter). I have a few small fixes which I'll include into the incoming PR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
