SamBarker commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1615688702
##########
pom.xml:
##########
@@ -54,11 +54,11 @@ under the License.
<maven.compiler.target>${java.version}</maven.compiler.target>
<slf4j.version>1.7.36</slf4j.version>
<log4j.version>1.2.17</log4j.version>
- <jmh.version>1.19</jmh.version>
+ <jmh.version>1.37</jmh.version>
<junit.version>4.13.2</junit.version>
<avro.version>1.11.1</avro.version>
<mockito.version>3.4.6</mockito.version>
- <maven.exec.version>1.6.0</maven.exec.version>
+ <maven.exec.version>3.3.0</maven.exec.version>
Review Comment:
The old version had issues trying to log `-p` so went for the most recent
release.
##########
pom.xml:
##########
@@ -54,11 +54,11 @@ under the License.
<maven.compiler.target>${java.version}</maven.compiler.target>
<slf4j.version>1.7.36</slf4j.version>
<log4j.version>1.2.17</log4j.version>
- <jmh.version>1.19</jmh.version>
+ <jmh.version>1.37</jmh.version>
Review Comment:
Needed a newer version for async-profiler support in JMH so went for the
most recent release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
