Zakelly commented on code in PR #90:
URL: https://github.com/apache/flink-benchmarks/pull/90#discussion_r1618445050
##########
benchmark.sh:
##########
@@ -0,0 +1,54 @@
+#!/usr/bin/env bash
Review Comment:
`chown +x` to make this executable?
##########
pom.xml:
##########
@@ -67,6 +67,7 @@ under the License.
<benchmarkExcludes>org.apache.flink.benchmark.full.*,org.apache.flink.state.benchmark.*,org.apache.flink.scheduler.benchmark.*</benchmarkExcludes>
<benchmarks>.*</benchmarks>
<executableJava>java</executableJava>
+ <jmhProfArgument> </jmhProfArgument>
Review Comment:
How about adding a property for path for profiling result? And I suggest a
relative path under current path for default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
