masteryhx commented on code in PR #24807:
URL: https://github.com/apache/flink/pull/24807#discussion_r1615759950
##########
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##########
@@ -431,7 +431,8 @@ public class CheckpointingOptions {
*
* <p>TODO: remove '@Documentation.ExcludeFromDocumentation' after the
feature is implemented.
Review Comment:
nit: Remove this.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##########
@@ -569,6 +581,67 @@ public void reusePreviousStateHandle(
}
}
+ // ------------------------------------------------------------------------
+ // Space Control
+ // ------------------------------------------------------------------------
+
+ /**
+ * The core method that control space if needed. This method will compare
the desired space
+ * amplification with current one, and if it exceeds the configured
amplification, this method
+ * will mark minimal set of {@link PhysicalFile}s not to be reused anymore.
+ */
+ private void controlSpace() {
+ if (spaceStat.logicalFileSize.get() * maxSpaceAmplification
Review Comment:
Could we just add a method in `SpaceStat` about `SpaceAmplification` ?
Then It could also be exposed by metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
