XComp commented on code in PR #24426:
URL: https://github.com/apache/flink/pull/24426#discussion_r1616177599
##########
.github/workflows/nightly.yml:
##########
@@ -94,3 +94,46 @@ jobs:
s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }}
s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY }}
s3_secret_key: ${{ secrets.IT_CASE_S3_SECRET_KEY }}
+
+ build_python_wheels:
+ name: "Build Python Wheels on ${{ matrix.os_name }}"
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - os: ubuntu-latest
+ os_name: linux
+ - os: macos-latest
+ os_name: macos
+ steps:
+ - name: "Checkout the repository"
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: "Stringify workflow name"
+ uses: "./.github/actions/stringify"
+ id: stringify_workflow
+ with:
+ value: ${{ github.workflow }}
+ - name: "Build python wheels for ${{ matrix.os_name }}"
+ uses: pypa/[email protected]
Review Comment:
Interesting approach. It's just that Apache doesn't allow actions other than
the ones from the `apache`, `github` and `actions`
([source](https://infra.apache.org/github-actions-policy.html)). We could use a
fixed version for the custom action and review that specific version. But
`pypa/[email protected]` seems to be a bigger project. I'm wondering whether
it's worth it or just use the previous approach (even though I liked your
intention 👍 ). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
