[ 
https://issues.apache.org/jira/browse/FLINK-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701736#comment-15701736
 ] 

ASF GitHub Bot commented on FLINK-5026:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2788#discussion_r89759486
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/ConnectedStreams.java
 ---
    @@ -234,62 +235,62 @@ public StreamExecutionEnvironment 
getExecutionEnvironment() {
        }
     
        /**
    -    * Applies the given {@link TimelyCoFlatMapFunction} on the connected 
input streams,
    +    * Applies the given {@link CoProcessFunction} on the connected input 
streams,
         * thereby creating a transformed output stream.
         *
         * <p>The function will be called for every element in the streams and 
can produce
         * zero or more output. The function can also query the time and set 
timers. When
         * reacting to the firing of set timers the function can emit yet more 
elements.
         *
    --- End diff --
    
    I would transform it into (to also show the distinction between flatMap): 
    
    <p>The function will be called for every element in the input streams and 
can produce zero or more
         * output elements. Contrary to the {@link #flatMap(CoFlatMapFunction)} 
function, this function can also
         * query the time and set timers. When reacting to the firing of set 
timers the function can directly
         * emit elements and/or register yet more timers.


> Rename TimelyFlatMap to Process
> -------------------------------
>
>                 Key: FLINK-5026
>                 URL: https://issues.apache.org/jira/browse/FLINK-5026
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>             Fix For: 1.2.0
>
>
> The method on {{KeyedDataStream}} would be called {{process()}} and the 
> function itself would be called {{ProcessFunction}}.
> The reason for this is that {{TimelyFlatMapFunction}} is a bit of a mouthful 
> and with the additions to the timer API and state the {{ProcessFunction}} 
> could become the basic, low-level, user-facing API for cases where users 
> nowadays implement their own operator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to