lincoln-lil commented on code in PR #24890:
URL: https://github.com/apache/flink/pull/24890#discussion_r1630964066
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/ExtractionUtils.java:
##########
@@ -844,7 +846,14 @@ private static class ParameterExtractor extends
ClassVisitor {
}
List<String> getParameterNames() {
- return parameterNames;
+ // method parameters are always at the head in the 'index' list
Review Comment:
It is recommended moving this description to the class comments, and also
update the example to illustrate the need to sort by index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
